Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: remove amd64_adx build tag in favor of GOAMD64 env var #181

Closed
gbotrel opened this issue May 10, 2022 · 2 comments
Closed

build: remove amd64_adx build tag in favor of GOAMD64 env var #181

gbotrel opened this issue May 10, 2022 · 2 comments
Labels
cleanup Suggestion to clean up the code

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented May 10, 2022

See here .

If GOAMD64 <= v2, use generic code.
@gbotrel gbotrel added the cleanup Suggestion to clean up the code label May 10, 2022
@gbotrel gbotrel added this to the v0.8.0 milestone May 10, 2022
@gbotrel
Copy link
Collaborator Author

gbotrel commented May 11, 2022

Additionnaly, that would fix the data race detected by CI

WARNING: DATA RACE
Read at 0x0000009a54cb by goroutine 25:
  github.com/consensys/gnark-crypto/ecc/bls12-377/fp.TestElementSqrt()
      /home/gb/dev/go/src/github.com/consensys/gnark-crypto/ecc/bls12-377/fp/element_test.go:1582 +0x847
  testing.tRunner()
      /usr/local/go/src/testing/testing.go:1439 +0x213
  testing.(*T).Run.func1()
      /usr/local/go/src/testing/testing.go:1486 +0x47

@gbotrel gbotrel removed this from the v0.8.0 milestone May 31, 2022
@gbotrel
Copy link
Collaborator Author

gbotrel commented Jun 1, 2022

Postponing until at least Go 1.19. Current for gnark and gnark-crypto libraries doesn't rely on users tweaking env vars, keep like this for now.

@gbotrel gbotrel closed this as completed Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cleanup Suggestion to clean up the code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gbotrel