Refactor codebase #144
Merged
Refactor codebase #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
reviewed
Nov 18, 2019
| @@ -40,9 +40,7 @@ Options: | |||
| --ignore-commit-pattern [regex] # pattern to ignore when parsing commits | |||
| --tag-pattern [regex] # override regex pattern for release tags | |||
| --tag-prefix [prefix] # prefix used in version tags, default: v | |||
| --starting-commit [hash] # starting commit to use for changelog generation | |||
There was a problem hiding this comment.
this is a semver major then?
There was a problem hiding this comment.
Yep. Will publish 2.0.0 once this is done and merged. It's not completely "breaking" as I guess it will just ignore this param and still generate a changelog (albiet one with more commits than desired) but a major bump feels cleaner.
cookpete
force-pushed
the
refactor-git-logic
branch
from
9579fd8 to
da22be6
Compare
- Use `git tags` and then an individual `git log` for each release Breaking changes: - Removes `--starting-commit` option - Commits are no longer fetched in one long list, so this option no longer makes any sense - Removes `--include-branch` option - No longer necessary now that releases are fetched via `git tags`
Seems like overkill to have so many dependendies and a build step to just support `import` and `export` Breaking changes: - Requires node 8.3 or higher - Removes all `lib` files from npm package
cookpete
force-pushed
the
refactor-git-logic
branch
from
da22be6 to
0aff625
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git tagsand then an individualgit logfor each releasebabelto compile tolibcore-jsBreaking changes:
--starting-commitoption--starting-versionequivalent--include-branchoptionTodo: