Switch to Streamable iFrame player

[lawlmart]

We’ve removed the files attribute from our API. In the future all videos must be played using our iframe player (similar to YouTube). The embed code is now returned by the API.

[cookpete]

@lawlmart This is quite a shame.. Is there a way to programmatically control the iframe player and receive events? Otherwise there is not much point for ReactPlayer to support Streamable videos.

[lawlmart]

Yes, we support player.js.

https://github.com/embedly/player.js/

[cookpete]

Thanks @lawlmart. I've just hooked it up but annoyingly there is a bug in the Streamable iframe when calling play() after the ready event where the thumbnail overlay remains on top of the playing video. It requires a user click to remove the overlay.

See example fiddle using pretty much the exact example code from the player.js readme.

[lawlmart]

Thanks for catching that, I’ll get that fixed ASAP.

[lawlmart]

Fiddle looks good now.

[cookpete]

Nice work on the fix @lawlmart. Next issue is that the player seems to fail karma tests when run in Travis (see failing build). I've had to skip the tests for the time being. The tests seem fine when run locally. That are pretty straightforward tests that pass on certain events/callbacks (see example test). Any ideas why this would happen?

[lawlmart]

What browser are you testing in?

…

On Sat, Sep 16, 2017 at 5:57 PM Pete Cook ***@***.***> wrote: Nice work on the fix @lawlmart <https://github.com/lawlmart>. Next issue is that the player seems to fail karma tests when run in Travis (see failing build <https://travis-ci.org/CookPete/react-player/builds/276018886>). I've had to skip the tests for the time being. The tests seem fine when run locally. That are pretty straightforward tests that pass on certain events/callbacks (see example test <https://github.com/CookPete/react-player/blob/master/test/specs/ReactPlayer.js#L97-L120>). Any ideas why this would happen? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#237 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKelVhzZfJQtYgNgPm3_0OjljLJ2LqTPks5si-_9gaJpZM4PYnQC> .

[cookpete]

CI tests currently run in Chromium 60.0.3112 on Ubuntu.

[lawlmart]

I'd figure one of the events isn't being called judging by the timeout, but it's hard to tell which. The player is passing the playerjs tester so I'm not sure what the issue is on our end. Which URL are you testing it with?

Edit: Chromium recently disabled autoplaying without user interaction. Perhaps this is an issue?