-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to react 15 #56
Comments
I have upgraded to latest React locally and I've had to fix a couple of issues that came up. I also wasn't sure what to do about |
ah ok! That is indeed the best way. So is that already in 0.5.7 version of react-player? |
Nope, I haven't pushed that yet. I want to make sure everything works ok, and I'm rejigging some of the test structure while I'm at it. Once I'm happy I'll push |
Nice work man! Let me know if I can help you with something on my fork. |
|
WoW! 👍 That was quick and Thanks! |
I couldn't see any more problems, and I didn't want to sit on it for too long ;) |
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Use `*` for react peer dependency to retain backward compatibility Resolves cookpete/react-player#56
Hi, Would be nice if the react-player will also require 15.0.1 (at the time of writing) and not depend only on 0.14.
Thanks!
The text was updated successfully, but these errors were encountered: