-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal of OpenAPI 3 #133
Comments
Hello @fmigneault ! Thanks for your submission :) Looks like a solid start! I must admit that my review queue is pretty big and this project has pretty low priority unfortunately :( In case it takes too long for us to give you reviews, I wouldn't be against giving write permissions to this repo to make it more agile. @gabisurita how are things on your side? |
That's fine. It will take me some time to make a clean PR. I want to add more tests also because it's quite a big amount of new features. |
Heyo how is stuff going? |
@Manuelraa But this is still thightly coupled to the extended classes located here: I still have yet to find some time to extract it an make a clean PR here. |
Hi!
I've been working on OpenAPI-3 support (#69) building on top of the code of this repo. I've got it working now. My code is not completely cleaned up and I can't have possibly tested all API use cases, but I would be happy make it into a proper PR if the maintainers are also willing to support it here.
The changes for the current code are as follows:
master...fmigneault:oneOf-objects
Plus the following objects I added in my repo to override/expand the existing converters:
https://github.com/crim-ca/weaver/blob/job-io-extras/weaver/wps_restapi/colander_extras.py
I'm using the following spec (quite big):
https://github.com/crim-ca/weaver/blob/job-io-extras/weaver/wps_restapi/swagger_definitions.py
I'm getting the results/features like follows :
oneOf
,allOf
,anyOf
supported (withdeserialize()
validation) (oneOf, allOf, anyOf, not - keyword for objects and arrays #95)format
orpattern
of string type (and adds the appropriate validator for free)accept
orcontent_type
orrenderer
can make a separate item under theresponses.content
orrequestBody.content
as required by the spec.other things:
default
auto-replaced when using schema deserialization and other nice-to-have schema definitionstitle
when the auto-one is not so greatgenerate
and/or directly set inCorniceSwagger
class.Let me know of your thoughts and if we could improve it even more.
The text was updated successfully, but these errors were encountered: