Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove support for IBC < v3 #1434

Closed
webmaster128 opened this issue Sep 21, 2022 · 2 comments · Fixed by #1875
Closed

Remove support for IBC < v3 #1434

webmaster128 opened this issue Sep 21, 2022 · 2 comments · Fixed by #1875
Labels
Breaking (contracts) Compile-time breaking contracts
Milestone
2.0.0

Comments

@webmaster128
Copy link
Member

All the code with

#[cfg(not(feature = "ibc3"))]

should be removed and only the IBC v3+ interfaces should be supported.
@webmaster128 webmaster128 added the Breaking (contracts) Compile-time breaking contracts label Sep 21, 2022
@webmaster128 webmaster128 added this to the 2.0.0 milestone Sep 21, 2022
@chipshort
Copy link
Collaborator

Do we want to keep the ibc3 feature or should we also just remove the #[cfg(feature = "ibc3")] guards?

@chipshort chipshort mentioned this issue Sep 15, 2023
Merged
@webmaster128
Copy link
Member Author

just remove the #[cfg(feature = "ibc3")] guards

This. The cargo feature "ibcv3" should be removed and everything becomes IBC 3+.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Breaking (contracts) Compile-time breaking contracts
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[2.0] Remove old ibc-v1 CosmWasm/cosmwasm
2 participants
@webmaster128 @chipshort