Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make all query response types non-exhaustive #1559

Closed
2 of 12 tasks
webmaster128 opened this issue Jan 2, 2023 · 0 comments · Fixed by #1883
Closed
2 of 12 tasks

Make all query response types non-exhaustive #1559

webmaster128 opened this issue Jan 2, 2023 · 0 comments · Fixed by #1883
Milestone
2.0.0

Comments

@webmaster128
Copy link
Member

By using #[non_exhaustive] we ensure that adding new fields does not prevent contracts from compiling. But adding #[non_exhaustive] is a breaking change, so this goes into 2.0.

bank

  • SupplyResponse
  • BalanceResponse
  • AllBalanceResponse

ibc

  • PortIdResponse
  • ListChannelsResponse
  • ChannelResponse

staking

  • BondedDenomResponse
  • AllDelegationsResponse
  • DelegationResponse
  • AllValidatorsResponse
  • ValidatorResponse

wasm

  • ContractInfoResponse
@webmaster128 webmaster128 added this to the 2.0.0 milestone Jan 2, 2023
@chipshort chipshort mentioned this issue Sep 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.0.0
Development

Successfully merging a pull request may close this issue.

[2.0] Response changes CosmWasm/cosmwasm
1 participant
@webmaster128