Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor MockQuerier #1751

Closed
chipshort opened this issue Jun 28, 2023 · 2 comments · Fixed by #1977
Closed

Refactor MockQuerier #1751

chipshort opened this issue Jun 28, 2023 · 2 comments · Fixed by #1977
Milestone

Comments

@chipshort
Copy link
Collaborator

The MockQuerier currently hides away its inner queriers. This forces us to forward all methods to make them available.
Exposing the underlying queriers directly would make it a little less boilerplatey.

#1593 (comment)

@chipshort chipshort changed the title Refactor mock queriers Refactor MockQuerier Jun 28, 2023
@chipshort
Copy link
Collaborator Author

chipshort commented Dec 13, 2023

@webmaster128 Is this something we want to do in 2.0?

That would allow us to remove all the forwarded function calls and just expose the inner queriers directly.
Otherwise, we'll have to keep the currently forwarded functions for backwards compatibility.

@webmaster128
Copy link
Member

Yeah why not, let's give it a try and see how it would look like.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants