Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gRPC query improvements #2091

Closed
chipshort opened this issue Apr 9, 2024 · 1 comment · Fixed by #2120
Closed

gRPC query improvements #2091

chipshort opened this issue Apr 9, 2024 · 1 comment · Fixed by #2120
Milestone

Comments

@chipshort
Copy link
Collaborator

It is incompatible with QuerierWrapper's query because query requires a json-decodable response (but the gRPC query is protobuf). query_raw works, but requires already-serialized input and is hard to use.

  • Document this on the gRPC query (and maybe add sample code on how to query)
  • Refactor out the part of the query function without the from_json call (that's what fails for gRPC).
  • Maybe we want to provide a direct query_grpc(path, data) -> Binary function using the refactored out part?
@webmaster128
Copy link
Member

Let's do that. It's just a shame that the nice name "query" is taken already and cannot be used for the more general case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants