Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The GovMsg message is not annotated as #[non_exhaustive] #2347

Open
DariuszDepta opened this issue Jan 22, 2025 · 0 comments
Open

The GovMsg message is not annotated as #[non_exhaustive] #2347

DariuszDepta opened this issue Jan 22, 2025 · 0 comments
Milestone

Comments

@DariuszDepta
Copy link
Member

The GovMsg message is not annotated as #[non_exhaustive], maybe it is a good time now to make it future proof:

/// ```
#[cfg(feature = "stargate")]
#[derive(Serialize, Deserialize, Clone, Debug, PartialEq, Eq, JsonSchema)]
#[serde(rename_all = "snake_case")]
pub enum GovMsg {
/// This maps directly to [MsgVote](https://github.com/cosmos/cosmos-sdk/blob/v0.42.5/proto/cosmos/gov/v1beta1/tx.proto#L46-L56) in the Cosmos SDK with voter set to the contract address.
Vote {
proposal_id: u64,
/// The vote option.
///
/// This used to be called "vote", but was changed for consistency with Cosmos SDK.
option: VoteOption,
},
/// This maps directly to [MsgVoteWeighted](https://github.com/cosmos/cosmos-sdk/blob/v0.45.8/proto/cosmos/gov/v1beta1/tx.proto#L66-L78) in the Cosmos SDK with voter set to the contract address.
#[cfg(feature = "cosmwasm_1_2")]
VoteWeighted {
proposal_id: u64,
options: Vec<WeightedVoteOption>,
},
}

@chipshort chipshort added this to the 3.0.0 milestone Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants