Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Api methods in cosmwasm_std::ExternalApi #757

Closed
ethanfrey opened this issue Jan 27, 2021 · 1 comment
Closed

Implement Api methods in cosmwasm_std::ExternalApi #757

ethanfrey opened this issue Jan 27, 2021 · 1 comment

Comments

@ethanfrey
Copy link
Member

Part of #751
Requires #756

  • Add imports to cosmwasm_vm::Instance for all the calls in cosmwasm_std::Api trait
  • Use same implementation as in MockApi to implement these calls in the vm (native code)
  • Add hooks in cosmwasm_std::ExternalApi to call these new entry points
  • Add integration tests to the sample crypto app. Ensure these calls work full stack (request -> wasm, wasm -> vm -> wasm for verification, wasm -> response)
@webmaster128
Copy link
Member

It turned out to be more helpful to work on the whole stack at once, and split the work algorithm by algorithm. As a consequence, this will always be done automatically for each method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants