Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression tests #68

Open
lewis6991 opened this issue Feb 13, 2025 · 2 comments
Open

Regression tests #68

lewis6991 opened this issue Feb 13, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@lewis6991
Copy link

Hi @CppCXY . As you know I've been raising lots of issues related to type analysis and diagnostics. You've been really good and responsive to fixing every single one of these, however I noticed that most (all?) of the commits to fix these issues are omitting regression tests. I noticed there are some tests, but I can't see many being added in any recent commits. Is this a temporary practice, and do you have any plans to introduce regression tests in the future.

I ask for two reasons:

  • I'd like Neovim and my projects to eventually adopt this tool, and having a strong testsuite would give us good confidence.
  • I'd like to eventually contribute to this tool, and having a strong testsuite would make that easier.

Thanks.

@CppCXY
Copy link
Owner

CppCXY commented Feb 13, 2025

Most of my tests were written in the early stages of the project. I usually write tests for every change in the parser, but for the code analysis part, I have indeed written very few tests. This is mainly because my ideas often change, and the interfaces change frequently. If I wrote tests for every step, this project might not have been released yet.

However, you are right. The project now has many features, and without a significant amount of test code, it is difficult to ensure the quality of future development. Therefore, I plan to add some tests this weekend.

@CppCXY CppCXY added the enhancement New feature or request label Feb 13, 2025
@lewis6991
Copy link
Author

I can see commits are getting tests now so I think this can be closed. I'll let you close it in the case you are keeping this ticket open for any other reasons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants