Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test System for DBTNG #1

Open
fiasco opened this issue Jan 4, 2011 · 4 comments
Open

Test System for DBTNG #1

fiasco opened this issue Jan 4, 2011 · 4 comments

Comments

@fiasco
Copy link

fiasco commented Jan 4, 2011

Now that DBTNG is out of Drupal, it no longer has simpletest. In light of existing schema issues Drupal is facing with PostgreSQL and SQLite. Should would conceive a test system within the framework that can ensure the way DBTNG i intended to work?

@Crell
Copy link
Owner

Crell commented Jan 4, 2011

Yes we should! I actually believe we should use PHPUnit. It's reasonably similar to Simpletest, at least on the test level, and it is far and away the most popular testing framework for PHP. Most of our tests from Drupal core can probably port over fairly easily, aside from the schema-related parts. Schema API is the least portable part anyway, so we'll probably need to do quite a bit of work there.

@fiasco
Copy link
Author

fiasco commented Jan 4, 2011

I've forked your repository and have begun working on a test framework based on PHPUnit. So far so good. Some things to ponder over though:

  1. I introduced a constant called DBTNG_DIR in place of DRUPAL_ROOT
  2. t() is everywhere. What should we do about that?
  3. I added the database section of the settings.php file to the code base as it has nice documentation and makes sense.

@Crell
Copy link
Owner

Crell commented Jan 24, 2011

  1. Sounds good.

  2. For the time being, I'd say rip it out entirely. That's too Drupal-specific. We'll have to figure out some other approach later, if we decide one is warranted.

  3. Sounds good.

Let me know when you have a pull request for me to merge back in. :-)

@fiasco
Copy link
Author

fiasco commented Apr 2, 2011

Is ripping the translation stuff out really a good idea? How does Drupal then merge DBTNG changes back into its core?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants