Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply debian incompatible-pointer-types.patch #210

Open
mtasaka opened this issue Jan 16, 2025 · 0 comments
Open

Apply debian incompatible-pointer-types.patch #210

mtasaka opened this issue Jan 16, 2025 · 0 comments

Comments

@mtasaka
Copy link

mtasaka commented Jan 16, 2025

As of f35db54 , compiling clipit with gcc14 (which defaults to have -Werror=incompatible-pointer-types) causes errors like:

main.c: In function ‘underline_match’:
main.c:618:29: error: passing argument 1 of ‘gtk_label_set_attributes’ from incompatible pointer type [-Wincompatible-pointer-types]
  618 |   gtk_label_set_attributes (gtk_label, attr_list);
      |                             ^~~~~~~~~
      |                             |
      |                             GtkWidget * {aka struct _GtkWidget *}
/usr/include/gtk-3.0/gtk/gtklabel.h:100:67: note: expected ‘GtkLabel *’ {aka ‘struct _GtkLabel *’} but argument is of type ‘GtkWidget *’ {aka ‘struct _GtkWidget *’}
  100 | void                  gtk_label_set_attributes    (GtkLabel      *label,
      |                                                    ~~~~~~~~~~~~~~~^~~~~
main.c: In function ‘selected_by_input’:
main.c:641:47: error: passing argument 1 of ‘gtk_container_get_children’ from incompatible pointer type [-Wincompatible-pointer-types]
  641 |   GList* element = gtk_container_get_children(menu);
      |                                               ^~~~
      |                                               |
      |                                               GtkMenuShell * {aka struct _GtkMenuShell *}
In file included from /usr/include/gtk-3.0/gtk/gtkbin.h:33,
                 from /usr/include/gtk-3.0/gtk/gtkwindow.h:35:
/usr/include/gtk-3.0/gtk/gtkcontainer.h:169:62: note: expected ‘GtkContainer *’ {aka ‘struct _GtkContainer *’} but argument is of type ‘GtkMenuShell *’ {aka ‘struct _GtkMenuShell *’}
  169 | GList*   gtk_container_get_children     (GtkContainer       *container);
      |                                          ~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
main.c:660:32: error: passing argument 1 of ‘gtk_widget_set_sensitive’ from incompatible pointer type [-Wincompatible-pointer-types]
  660 |       gtk_widget_set_sensitive(menu_item, true);
      |                                ^~~~~~~~~
      |                                |
      |                                GtkMenuItem * {aka struct _GtkMenuItem *}
/usr/include/gtk-3.0/gtk/gtkwidget.h:840:72: note: expected ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} but argument is of type ‘GtkMenuItem *’ {aka ‘struct _GtkMenuItem *’}
  840 | void                  gtk_widget_set_sensitive          (GtkWidget    *widget,
      |                                                          ~~~~~~~~~~~~~~^~~~~~
main.c:662:32: error: passing argument 1 of ‘gtk_widget_set_sensitive’ from incompatible pointer type [-Wincompatible-pointer-types]
  662 |       gtk_widget_set_sensitive(menu_item, false);
      |                                ^~~~~~~~~
      |                                |
      |                                GtkMenuItem * {aka struct _GtkMenuItem *}
/usr/include/gtk-3.0/gtk/gtkwidget.h:840:72: note: expected ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} but argument is of type ‘GtkMenuItem *’ {aka ‘struct _GtkMenuItem *’}
  840 | void                  gtk_widget_set_sensitive          (GtkWidget    *widget,
      |                                                          ~~~~~~~~~~~~~~^~~~~~
main.c:670:42: error: passing argument 2 of ‘gtk_menu_shell_select_item’ from incompatible pointer type [-Wincompatible-pointer-types]
  670 |         gtk_menu_shell_select_item(menu, first_match);
      |                                          ^~~~~~~~~~~
      |                                          |
      |                                          GtkMenuItem * {aka struct _GtkMenuItem *}
In file included from /usr/include/gtk-3.0/gtk/gtkmenu.h:33:
/usr/include/gtk-3.0/gtk/gtkmenushell.h:104:55: note: expected ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} but argument is of type ‘GtkMenuItem *’ {aka ‘struct _GtkMenuItem *’}
  104 |                                         GtkWidget    *menu_item);
      |                                         ~~~~~~~~~~~~~~^~~~~~~~~
keybinder.c: In function ‘keybinder_is_modifier’:
keybinder.c:313:33: error: passing argument 1 of ‘gdk_window_get_display’ from incompatible pointer type [-Wincompatible-pointer-types]
  313 |             GDK_WINDOW_XDISPLAY(gdk_display_get_default()));
      |                                 ^~~~~~~~~~~~~~~~~~~~~~~~~
      |                                 |
      |                                 GdkDisplay * {aka struct _GdkDisplay *}
/usr/include/gtk-3.0/gdk/x11/gdkx11display.h:59:70: note: in definition of macro ‘GDK_DISPLAY_XDISPLAY’
   59 | #define GDK_DISPLAY_XDISPLAY(display) (gdk_x11_display_get_xdisplay (display))
      |                                                                      ^~~~~~~
keybinder.c:313:13: note: in expansion of macro ‘GDK_WINDOW_XDISPLAY’
  313 |             GDK_WINDOW_XDISPLAY(gdk_display_get_default()));
      |             ^~~~~~~~~~~~~~~~~~~
In file included from /usr/include/gtk-3.0/gdk/gdkseat.h:28,
                 from /usr/include/gtk-3.0/gdk/gdkdisplay.h:33,
                 from /usr/include/gtk-3.0/gdk/gdkscreen.h:32,
                 from /usr/include/gtk-3.0/gdk/gdkapplaunchcontext.h:31,
                 from /usr/include/gtk-3.0/gdk/gdk.h:32:
/usr/include/gtk-3.0/gdk/gdkwindow.h:525:64: note: expected ‘GdkWindow *’ {aka ‘struct _GdkWindow *’} but argument is of type ‘GdkDisplay *’ {aka ‘struct _GdkDisplay *’}
  525 | GdkDisplay *  gdk_window_get_display           (GdkWindow     *window);
      |                                                 ~~~~~~~~~~~~~~~^~~~~~
preferences.c:828:14: error: assignment to ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} from incompatible pointer type ‘GtkAdjustment *’ {aka ‘struct _GtkAdjustment *’} [-Wincompatible-pointer-types]
  828 |   adjustment = gtk_adjustment_new(25, 5, 1000, 1, 10, 0);
      |              ^
preferences.c:835:3: warning: ‘gtk_misc_set_alignment’ is deprecated [-Wdeprecated-declarations]
  835 |   gtk_misc_set_alignment((GtkMisc*)label, 0.0, 0.50);
      |   ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:9: note: declared here
   72 | void    gtk_misc_set_alignment (GtkMisc *misc,
      |         ^~~~~~~~~~~~~~~~~~~~~~
preferences.c:837:20: error: assignment to ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} from incompatible pointer type ‘GtkAdjustment *’ {aka ‘struct _GtkAdjustment *’} [-Wincompatible-pointer-types]
  837 |   adjustment_small = gtk_adjustment_new(25, 5, 100, 1, 10, 0);
      |                    ^
preferences.c:847:3: warning: ‘gtk_misc_set_alignment’ is deprecated [-Wdeprecated-declarations]
  847 |   gtk_misc_set_alignment((GtkMisc*)label, 0.0, 0.50);
      |   ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:9: note: declared here
   72 | void    gtk_misc_set_alignment (GtkMisc *misc,
      |         ^~~~~~~~~~~~~~~~~~~~~~
preferences.c:849:22: error: assignment to ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} from incompatible pointer type ‘GtkAdjustment *’ {aka ‘struct _GtkAdjustment *’} [-Wincompatible-pointer-types]
  849 |   adjustment_statics = gtk_adjustment_new(10, 1, 100, 1, 10, 0);
      |                      ^
preferences.c:861:3: warning: ‘gtk_misc_set_alignment’ is deprecated [-Wdeprecated-declarations]
  861 |   gtk_misc_set_alignment((GtkMisc*)label, 0.0, 0.50);
      |   ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:9: note: declared here
   72 | void    gtk_misc_set_alignment (GtkMisc *misc,
      |         ^~~~~~~~~~~~~~~~~~~~~~
preferences.c:863:20: error: assignment to ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} from incompatible pointer type ‘GtkAdjustment *’ {aka ‘struct _GtkAdjustment *’} [-Wincompatible-pointer-types]
  863 |   adjustment_small = gtk_adjustment_new(0, 1, 100, 1, 10, 0);
      |                    ^

preferences.c:891:14: error: assignment to ‘GtkWidget *’ {aka ‘struct _GtkWidget *’} from incompatible pointer type ‘GtkAdjustment *’ {aka ‘struct _GtkAdjustment *’} [-Wincompatible-pointer-types]
  891 |   adjustment = gtk_adjustment_new(50, 25, 75, 1, 5, 0);
      |              ^
preferences.c:898:3: warning: ‘gtk_misc_set_alignment’ is deprecated [-Wdeprecated-declarations]
  898 |   gtk_misc_set_alignment((GtkMisc*)label, 0.0, 0.50);
      |   ^~~~~~~~~~~~~~~~~~~~~~
/usr/include/gtk-3.0/gtk/deprecated/gtkmisc.h:72:9: note: declared here
   72 | void    gtk_misc_set_alignment (GtkMisc *misc,
      |         ^~~~~~~~~~~~~~~~~~~~~~
preferences.c:901:34: error: passing argument 1 of ‘gtk_combo_box_text_append_text’ from incompatible pointer type [-Wincompatible-pointer-types]
  901 |   gtk_combo_box_text_append_text((GtkComboBox*)ellipsize_combo, _("Beginning"));
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  |
      |                                  GtkComboBox * {aka struct _GtkComboBox *}
In file included from /usr/include/gtk-3.0/gtk/gtk.h:80:
/usr/include/gtk-3.0/gtk/gtkcomboboxtext.h:67:72: note: expected ‘GtkComboBoxText *’ {aka ‘struct _GtkComboBoxText *’} but argument is of type ‘GtkComboBox *’ {aka ‘struct _GtkComboBox *’}
   67 | void          gtk_combo_box_text_append_text     (GtkComboBoxText     *combo_box,
      |                                                   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
preferences.c:902:34: error: passing argument 1 of ‘gtk_combo_box_text_append_text’ from incompatible pointer type [-Wincompatible-pointer-types]
  902 |   gtk_combo_box_text_append_text((GtkComboBox*)ellipsize_combo, _("Middle"));
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  |
      |                                  GtkComboBox * {aka struct _GtkComboBox *}
/usr/include/gtk-3.0/gtk/gtkcomboboxtext.h:67:72: note: expected ‘GtkComboBoxText *’ {aka ‘struct _GtkComboBoxText *’} but argument is of type ‘GtkComboBox *’ {aka ‘struct _GtkComboBox *’}
   67 | void          gtk_combo_box_text_append_text     (GtkComboBoxText     *combo_box,
      |                                                   ~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~
preferences.c:903:34: error: passing argument 1 of ‘gtk_combo_box_text_append_text’ from incompatible pointer type [-Wincompatible-pointer-types]
  903 |   gtk_combo_box_text_append_text((GtkComboBox*)ellipsize_combo, _("End"));
      |                                  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
      |                                  |
      |                                  GtkComboBox * {aka struct _GtkComboBox *}

These can be resolved by debian incompatible-pointer-types.patch:
https://salsa.debian.org/debian/clipit/-/blob/main/debian/patches/incompatible-pointer-types.patch?ref_type=heads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant