Inconsistent model mapping (domain_user)

[martinalbert]

This issue describes inconsistent mapping of model DomainUser. This change happened in 97a9111.

Current structure of DomainUser from endpoint https://api.crowdstrike.com/user-management/entities/users/GET/v1:

Type in code:

gofalcon/falcon/models/domain_user.go

Lines 18 to 34 in 48f6999

	type DomainUser struct {
	// cid
	Cid string `json:"cid,omitempty"`
	// email
	Email string `json:"email,omitempty"`
	// first name
	FirstName string `json:"firstName,omitempty"`
	// last name
	LastName string `json:"lastName,omitempty"`
	// uuid
	UUID string `json:"uuid,omitempty"`
	}

Other types of DomainUser like DomainCreateUserRequest contain the old structure:

gofalcon/falcon/models/domain_create_user_request.go

Lines 18 to 34 in 48f6999

	type DomainCreateUserRequest struct {
	// cid
	Cid string `json:"cid,omitempty"`
	// first name
	FirstName string `json:"first_name,omitempty"`
	// last name
	LastName string `json:"last_name,omitempty"`
	// password
	Password string `json:"password,omitempty"`
	// uid
	UID string `json:"uid,omitempty"`
	}

[ffalor]

I believe this is fixed in 0.7.0-rc1 it looks like multiple endpoints are defining that model. I'll keep an eye on it for future client generations to ensure it doesn't happen again.

[martinalbert]

Thank you @ffalor, seems like the release action went through, but I can't use the new release candidate. I can't find it in go registry as well: https://pkg.go.dev/github.com/crowdstrike/gofalcon?tab=versions.

[ffalor]

It's because it's marked as a pre-release. You can install it by running go get github.com/crowdstrike/gofalcon/[email protected]

It will look like this in your go.mod file: github.com/crowdstrike/gofalcon v0.6.1-0.20240426204036-ac8ce2b4f2d7

[martinalbert]

My bad, thank you again @ffalor, it works!