made logger class available to be downcasted into std::ostream #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
sorry this class did not work correctly, so I will reopen when successfully implemented... |
|
Fixed and confirmed posting to Max console properly. If I should squash commit, I will. |
tomoyanonymous
force-pushed
the
feature_logger_ostream
branch
from
461e6cb to
cf05754
Compare
|
Hi @tomoyanonymous ! Before I can review your PRs I need you to sign our CLA at https://cycling74.com/cla You only need to do this one time. Thanks! |
|
Sent! Best regards. |
tomoyanonymous
force-pushed
the
feature_logger_ostream
branch
from
b21c932 to
614d72b
Compare
tomoyanonymous
force-pushed
the
feature_logger_ostream
branch
from
614d72b to
b81d174
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a kind of feature request though there's no API breaking, that
loggerclass can be downcasted intostd::ostream&so that user can post messages to Max window from classes in their own library.Diff looks dirty but I used .clang-format on this repository.