Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CMakeLists.txt
add_subdirectory()
the max-sdk-base.min-api-test-headers
(used for unit tests).c74_add_min_target.cmake
c74_add_min_target()
formin-pretarget.cmake
/min-posttarget.cmake
c74_add_max_target()
and creates a library target as well as a project and appends some additional definitions.c74_add_max_target()
); no need to check xcode version (done inCMakeLists.txt
); no need to check OSX architectures (done inc74_add_max_target()
))min-posttarget.cmake
for setting warning flags on mac has been refactored to a separate file.min-posttarget.cmake
CMakeLists.txt
.For uniformity:
Should/can we rename the
API
and theLIB
library targets tomin-api
andmin-lib
to match the repo name and therefore also give them a slightly more descriptive name (an alias to the old name can be created)?