Feature/466796 add page #710
Conversation
Add uqestion screen Add question details screen List questions page
Reduced some function sizes
|
|
||
| $defra-brand-colour: govuk-organisation-colour(department-for-environment-food-rural-affairs); | ||
|
|
||
| .editor-card { |
There was a problem hiding this comment.
purely for cleanliness, nice to have a line break in between parent/child class, bit pedantic I know.
designer/server/src/common/components/page-panel-left/template.njk
Outdated
Show resolved
Hide resolved
designer/server/src/common/components/page-panel-left/template.njk
Outdated
Show resolved
Hide resolved
| } | ||
| ] | ||
| }, | ||
| headers: { Authorization: `Bearer ${token}` } |
There was a problem hiding this comment.
if this is being reused, could be pulled out to a const.
| }, | ||
| useNewMasthead: true | ||
| } | ||
| } |
| const now = new Date() | ||
| const authorId = 'f50ceeed-b7a4-47cf-a498-094efc99f8bc' | ||
| const authorDisplayName = 'Enrique Chase' | ||
|
|
There was a problem hiding this comment.
would be nice to have these stored in a separate folder. If everyone else is happy with a __stubs__ folder (or some other name) so that they can be reused across tests. We can't use __mocks__ as eslint doesn't like imports from these directories.
| updatedAt: now, | ||
| updatedBy: author | ||
| } | ||
| } |
There was a problem hiding this comment.
A stub builder might help with these. Was a pattern colleagues used on an old project.
|
There was a problem hiding this comment.
Looks good to me, great stuff @jbarnsley10 👍 . This will need to be merged together with my PR I think.
Add page
Add question
List questions