Fixes related to sample data updates #523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pre-commit.ci autofix |
Cadair
force-pushed
the
post-1.10-fixes
branch
from
3846e44 to
3bcce68
Compare
Cadair
commented
Feb 10, 2025
Co-authored-by: Stuart Mumford <[email protected]>
CodSpeed Performance ReportMerging #523 will not alter performanceComparing Summary
|
This comment was marked as resolved.
This comment was marked as resolved.
Cadair
commented
Feb 10, 2025
Cadair
commented
Feb 11, 2025
Cadair
commented
Feb 11, 2025
braingram
reviewed
Feb 12, 2025
pytest.ini
Outdated
| @@ -70,3 +70,5 @@ filterwarnings = | |||
| ignore:pkg_resources is deprecated as an API.*:DeprecationWarning | |||
| ignore:Deprecated call to .*pkg_resources\.declare_namespace.*mpl_toolkits.*:DeprecationWarning | |||
| ignore:Extension .*sunpy-1\.0\.0:asdf.exceptions.AsdfManifestURIMismatchWarning | |||
| # This warning should go away in asdf-astropy 0.7.1 and we can stop being ignored then | |||
| ignore::asdf.exceptions.AsdfPackageVersionWarning | |||
There was a problem hiding this comment.
FYI: 0.7.1 with the fix is up on pypi. https://pypi.org/project/asdf-astropy/0.7.1/
Cadair
commented
Feb 12, 2025
Cadair
commented
Feb 18, 2025
SolarDrew
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #522
Closes #527