New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

digital signature dual verification is not robust #2395

Closed

jyao1 opened this issue Oct 9, 2023 · 1 comment · Fixed by #2397

Assignees

Labels

bug

Member

jyao1 commented Oct 9, 2023 •

edited

Loading

There might be small chance that the digital signature is same before and after swap.

For example: digital signature is 0xABCDDCBA.

Then we cannot distinguish little endian or big endian.

We need to skip endianness assignment in this case, such as add check for palindrome

Member Author

jyao1 commented Oct 9, 2023

Similar issue #2393

jyao1 added the bug label

jyao1 assigned richkong88

jyao1 linked a pull request

that will close this issue

Fix for wrong endian determination when signature is same for both #2397

Merged

jyao1 closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment