Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature request) Gallery reader 2.0 #104

Closed
ghost opened this issue Apr 26, 2020 · 2 comments
Closed

(Feature request) Gallery reader 2.0 #104

ghost opened this issue Apr 26, 2020 · 2 comments

Comments

@ghost
Copy link

ghost commented Apr 26, 2020

The reader in it's current state is already pretty good, so I had the idea of listing the remaining features for it to become a full-function reader, for every one of these that gets added to the client, I will update this and mark the feature as done, anyways here's the list:

2 of 2 bugs were patched in this post, to see what it's about check the edit history, if you are still having the removed glitch, please reply to this post reporting your experience.

-(New feature) Change page brightness button. (cancelled, explained in the developer's reply)

-(New feature) Image rotation. (done, added in 2.2.3)

-(New feature) display current hour, battery level, and internet status alongside the page number in the reader.

-(New feature) page navigator in single column mode in the toolbar, just like the regular page navigator in the reader, using the page navigator in single column mode should scroll you directly to the page you selected.

(Explained some ideas on how to make the toolbar list in the gallery page smaller in my reply to this post)

@Dar9586
Copy link
Owner

Dar9586 commented May 2, 2020

I added the option inside the single column mode by using long press, I couldn't use the navigation drawer due to Material design guideline (that states it could only be used to change the screen), and they cannot go in the toolbar because it has already a lot of options.
They can only be used inside single column mode because the image used is the one inside the grid, and they are very small already in 2 line grid.
The brightness option will not be added because many Android devices has them inside the status bar and implementing it inside the app would both be redundant and would decrease the overall performance of the visualization (because of the cost of the image manipulation)

@ghost
Copy link
Author

ghost commented May 2, 2020

Thanks for informing me about the limitations, it was really helpful to have an insight on how much is possible to do in the app, though I have some ideas to make the toolbar smaller for the gallery page:

-"download gallery" and "download page range" merged. (Done, added in 2.2.6)

-Same thing but for favorites, when you press the heart, you should be able to select if you want to add it local, online, or both. (Having this for every place in which the heart appears as a bonus would be great)

Adding these should make the toolbar smaller, which can make the page navigator on single column mode feature possible, thanks for reading these and putting effort on this, good luck!

@ghost ghost closed this as completed May 26, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant