Remove datadog checks

[Jno21]

This PR is a proposal for the issue 43.

By setting: datadog_disable_untracked_checks to true all the files that are not in datadog_checks and datadog_additional_checks will be removed.

datadog_additional_checks allow you to add some checks that won't be remove while running the ansible role with datadog_disable_untracked_checks: true.

If you have any feedback it will be appreciated, I am still new to Ansible :)

[rromanchuk]

thanks @Jno21, much needed, especially in the beginning of integration when the velocity of changes to these checks are high from testing/optimizing/rearrangingu integrations. Been burned a couple of times not realizing old checks were still running

[dabcoder]

@Jno21 Sorry about the long delay here. I'm currently testing this and it looks pretty good so far. Your branch is now out of sync with master, would you mind rebasing it on master then (we've split the agent 6 yaml file in 2 - Linux and Windows, and removed support for agent 5 on Windows)

[Jno21]

Hi, Sorry about the delay also. I rebased to be in sync with master, I also did it for Windows (I couldn't test it tho, so I am not 100% sure about it).
If the windows one is not correct I can drop the commit and we can still merge.

[dabcoder]

Left a couple of notes, thanks for getting back to us!

[izeau]

Is there any advancement on this? I'd love to be able to use this role without relying on @Jno21's fork! Thanks.

[KSerrania]

Thanks for the PR! I left some questions and suggestions.

There's a merge conflict because the README got updated on master (the list of attributes has become a table), could you update your PR to resolve the conflict?

[KSerrania]

On Agent 5, this directly matches files (as there are no <check>.d folders), so the file type should be changed accordingly (otherwise Ansible doesn't match anything since there are no directories ending in .yaml)

Suggested change

	file_type: directory
	file_type: file

[KSerrania]

This will remove any user-defined configuration of the checks, but in the case of core checks (disk, memory, etc.), they will still be running with the default configuration, as the default config file ({{ item }}.yaml.default) will still be present.
Is this expected? Or should the default files also be removed?

(Same question for Agent 6, with the conf.d/{{ item }}.d/conf.yaml.default files)

[lesteenman]

While it would be useful to keep them as a base case, I think it'll make things a lot complexer when people start modifying the defaults - and there are likely use cases where you want to remove the defaults anyway.

Maybe an additional config option (datadog_disable_default_checks)?

[Jno21]

Hey ! I followed @lesteenman idea by adding a datadog_disable_default_checks option (true or false). So it will remove all defaults checks or not.
If you want to go further with the idea you can pick it up to choose which one you will prefer to remove (list).

[KSerrania]

Suggested change

	- `datadog_additional_checks`: List of additional checks that won't be remove if `datadog_disable_untracked_checks` is set to `true`.
	- `datadog_additional_checks`: List of additional checks that won't be removed if `datadog_disable_untracked_checks` is set to `true`.

[Jno21]

Done

[lesteenman]

@Jno21, do you plan to finish this PR? I might be able to pick it up otherwise.

[Jno21]

Hey ! Sorry for the long wait, I made corrections like asked and added the idea of @lesteenman !
I didn't have time to test it (I am in vacation). So if somebody could make sure it is correct and working and after we are good to go :)
It will be cool to merge this PR :D

[kayayarai]

small grammar fix, otherwise good from a documentation perspective.

[albertvaka]

Thanks for your PR and sorry for the (very long) wait 🙇 LGTM and merging! 👍