Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[suse] Import the new GPG key #203

Merged
merged 4 commits into from
Aug 12, 2019
Merged

Conversation

KSerrania
Copy link
Contributor

In the near future, we're going to sign our RPM packages with our
newer GPG key. The RHEL task already imports the new key, but not the SUSE
task, so the new key import step has been added to it.

In the near future, we're going to sign our RPM packages with our
newer GPG key. The RHEL task already imports the new key, but not the SUSE
task, so the new key import step has been added to it.
Copy link
Member

@hush-hush hush-hush left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also update the CHANGELOG and the README to add a bit of documentation ?

@@ -31,6 +31,8 @@ datadog_yum_gpgkey_new: "https://yum.datadoghq.com/DATADOG_RPM_KEY_E09422B3.publ
datadog_zypper_repo: "https://yum.datadoghq.com/suse/stable/6/{{ ansible_userspace_architecture }}"
datadog_zypper_gpgkey: "https://yum.datadoghq.com/DATADOG_RPM_KEY.public"
datadog_zypper_gpgkey_sha256sum: "00d6505c33fd95b56e54e7d91ad9bfb22d2af17e5480db25cba8fee500c80c46"
datadog_zypper_gpgkey_new: "https://yum.datadoghq.com/DATADOG_RPM_KEY_E09422B3.public"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we rename the variable for something without new like datadog_zypper_gpgkey_E09422B3 (in order to preprare for the next key rotation) ?

@KSerrania KSerrania merged commit a87e6a6 into master Aug 12, 2019
@KSerrania KSerrania deleted the kserrania/add-new-RPM-key-SUSE branch August 12, 2019 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants