Ansible lint #50
Merged
Ansible lint #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olivielpeau
reviewed
Mar 31, 2017
.travis.yml
Outdated
| python: "2.7" | ||
|
|
||
| before_install: | ||
| - sudo apt-get update -qq |
There was a problem hiding this comment.
why this step? If it's not useful let's remove it
There was a problem hiding this comment.
Indeed! I added it because at first I thought ansible-lint would need ansible installed, but since it's not the case, let's delete it.
This ensures a minimum checkstyle is done on each push. ANSIBLE0010 is deliberately excluded since it can be argued that ensure=latest is actually the wanted behavior.
|
Thanks for the comments and for the good welcome of the PR :-P. I cleaned the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposition to activate a kind of Ansible check-style enforcement using
ansible-lint. It currently only ignores[EANSIBLE0010] Package installs should not use latestsince I'm not sure how you'd like to fix it.Please share your thoughts.