Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce flag to start/stop agent #94

Merged
merged 2 commits into from
Mar 20, 2014

Conversation

jedi4ever
Copy link
Contributor

This introduces a new node['datadog']['agent_start'] flag to control the behavior of the agent service.

@miketheman
Copy link
Contributor

@jedi4ever I understand what you're trying to do here, but it doesn't read very cleanly right now - is there anything you can do to clean up that conditional?

@miketheman miketheman added this to the Next minor milestone Mar 19, 2014
miketheman added a commit that referenced this pull request Mar 20, 2014
- remove logging statement
- convert conditional into concise ternary
- clean up style
miketheman added a commit that referenced this pull request Mar 20, 2014
@miketheman miketheman merged commit d6893d6 into DataDog:master Mar 20, 2014
@miketheman
Copy link
Contributor

Thanks @jedi4ever ! I changed the syntax slightly, but kept the attribute name and spirit.

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014
- remove logging statement
- convert conditional into concise ternary
- clean up style
n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants