-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Synthetics support #433
Conversation
22b0cfc
to
29340fc
Compare
a9fef7f
to
0655457
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Conflicts with master are the only things I can pick on |
0655457
to
4799bf3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Especially if this is good with you @jd .
Thanks 👏
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
Can't reproduce the failure locally. Re-running just in case to see if we get the same value for the number of tests. |
/azp run DataDog.datadogpy.integration |
Azure Pipelines successfully started running 1 pipeline(s). |
* Add synthetics resource * Add integration test * Fix delete path * Make the tests pass * Use set up and tear down methods to clean up * Add browser test in tests * Debug pause * Fix conflict in api_client re: error raised * Synthetics was missing in the helpers / tests * [Review feedback] Create separate classes for Synthetics API paths * Remove synthetics in helpers too
Add Synthetics support based on https://docs.datadoghq.com/api/?lang=bash#synthetics.