Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Synthetics support #433

Merged
merged 11 commits into from
Nov 8, 2019
Merged

Add Synthetics support #433

merged 11 commits into from
Nov 8, 2019

Conversation

dabcoder
Copy link
Contributor

@dabcoder dabcoder commented Sep 11, 2019

Add Synthetics support based on https://docs.datadoghq.com/api/?lang=bash#synthetics.

@dabcoder dabcoder force-pushed the davidb/synthetics branch 3 times, most recently from 22b0cfc to 29340fc Compare October 10, 2019 16:54
@dabcoder dabcoder marked this pull request as ready for review October 28, 2019 08:49
@dabcoder dabcoder requested a review from a team as a code owner October 28, 2019 08:49
Copy link

@Kerl1310 Kerl1310 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kerl1310
Copy link

Conflicts with master are the only things I can pick on

.gitignore Outdated Show resolved Hide resolved
datadog/api/api_client.py Outdated Show resolved Hide resolved
datadog/api/resources.py Outdated Show resolved Hide resolved
Copy link
Contributor

@gzussa gzussa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Especially if this is good with you @jd .
Thanks 👏

@dabcoder
Copy link
Contributor Author

dabcoder commented Nov 8, 2019

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dabcoder
Copy link
Contributor Author

dabcoder commented Nov 8, 2019

Can't reproduce the failure locally. Re-running just in case to see if we get the same value for the number of tests.

@dabcoder
Copy link
Contributor Author

dabcoder commented Nov 8, 2019

/azp run DataDog.datadogpy.integration

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dabcoder dabcoder merged commit 3c190f0 into DataDog:master Nov 8, 2019
@dabcoder dabcoder deleted the davidb/synthetics branch November 8, 2019 17:14
dabcoder pushed a commit to dabcoder/datadogpy that referenced this pull request Nov 28, 2019
* Add synthetics resource

* Add integration test

* Fix delete path

* Make the tests pass

* Use set up and tear down methods to clean up

* Add browser test in tests

* Debug pause

* Fix conflict in api_client re: error raised

* Synthetics was missing in the helpers / tests

* [Review feedback] Create separate classes for Synthetics API paths

* Remove synthetics in helpers too
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants