From 79c1a9ca33161c7936bdcaeb7f0cc4dc039cad47 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Herv=C3=A9?= Date: Fri, 5 Feb 2021 18:22:39 +0100 Subject: [PATCH 1/2] Turn EAGAIN error into debug It can be super verbose, let's keep it but reduce from warning. --- datadog/dogstatsd/base.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/datadog/dogstatsd/base.py b/datadog/dogstatsd/base.py index d7195b10e..db92b5fcd 100644 --- a/datadog/dogstatsd/base.py +++ b/datadog/dogstatsd/base.py @@ -609,7 +609,7 @@ def _xmit_packet(self, packet, is_telemetry): self.close_socket() except socket.error as se: if se.errno == errno.EAGAIN: - log.warning("Socket send would block: {}, dropping the packet".format(se)) + log.debug("Socket send would block: %s, dropping the packet", se) else: log.warning("Error submitting packet: {}, dropping the packet and closing the socket".format(se)) self.close_socket() From 1070432ef13e76981456535089634f1f9a718095 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Thomas=20Herv=C3=A9?= Date: Fri, 5 Feb 2021 18:31:40 +0100 Subject: [PATCH 2/2] Fix test --- tests/unit/dogstatsd/test_statsd.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/unit/dogstatsd/test_statsd.py b/tests/unit/dogstatsd/test_statsd.py index c8714dd8d..83ef2a2bf 100644 --- a/tests/unit/dogstatsd/test_statsd.py +++ b/tests/unit/dogstatsd/test_statsd.py @@ -383,8 +383,8 @@ def test_socket_overflown(self): with mock.patch("datadog.dogstatsd.base.log") as mock_log: self.statsd.gauge('no error', 1) mock_log.error.assert_not_called() - c = [call("Socket send would block: Socket error, dropping the packet")] - mock_log.warning.assert_has_calls(c * 2) + c = [call("Socket send would block: %s, dropping the packet", mock.ANY)] + mock_log.debug.assert_has_calls(c * 2) def test_distributed(self): """