Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should not be using netstat to gather socket connections in network.py #1156

Closed
tliakos opened this issue Oct 14, 2014 · 3 comments
Closed
Assignees
Milestone

Comments

@tliakos
Copy link

tliakos commented Oct 14, 2014

Should be using 'ss' as opposed to netstat. I have instances that are running with socket connections > 20000 - Netstat will either timeout or topple over before the metric is sent. Can we discuss changing this to ss since it gets its metrics directly from the kernel space as opposed to /proc (netstat) which is heavy.

(line 141) netstat = subprocess.Popen(["netstat", "-n", "-u", "-t", "-a"],
stdout=subprocess.PIPE,
close_fds=True).communicate()[0]

@tliakos tliakos changed the title Should not be using netstat to Should not be using netstat to gather socket connections in network.py Oct 14, 2014
@remh
Copy link

remh commented Nov 4, 2014

Thanks a lot @tliakos for the feedback!
We are going to investigate that issue for our 5.2.0 release.

@remh remh added this to the 5.2.0 milestone Nov 4, 2014
@remh remh modified the milestones: 5.3.0, 5.2.0 Jan 13, 2015
@remh remh modified the milestones: 5.4.0, 5.3.0 Mar 18, 2015
@yannmh yannmh modified the milestones: 5.5.0, 5.4.0 Jun 5, 2015
@yannmh yannmh modified the milestones: 5.6.0, 5.5.0 Jul 31, 2015
@joelvanvelden
Copy link

👍 Netstat is evil - it will throw out information to ensure output is formatted nicely - surely the worst design goal ever. Apparently this is not considered a bug!

https://bugzilla.redhat.com/show_bug.cgi?id=755905

this is expected behavior.
Netstat produces output formatted to approx. 80 characters wide.
To achieve this width, columns are truncated.

@yannmh
Copy link
Member

yannmh commented Nov 3, 2015

Fixed with #1859.

@yannmh yannmh closed this as completed Nov 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants