Add service check for gunicorn #1163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if working == 0 and idle == 0: | ||
| self.service_check(self.SVC_NAME, AgentCheck.CRITICAL, tags=['app:'+ proc_name]) | ||
| else: | ||
| self.service_check(self.SVC_NAME, AgentCheck.OK, tags=['app:'+ proc_name]) |
There was a problem hiding this comment.
Can we add a message with additional context to differentiate theses from the other service check later on? e.g.: "Found # idle and # working workers"? The one below could be something like "Found no master process with name ..."
Closed
|
|
||
| msg = "%s working and %s idle workers for %s" % (working, idle, proc_name) | ||
|
|
||
| if working == 0 and idle == 0: |
There was a problem hiding this comment.
why not clean this up a bit?
status = CRIT if working == 0 and idle == 0 else OK
self.service_check(self.SVC_NAME, status, tags=['app:'+ proc_name], message=msg)
it makes the intent clearer. always submit a value, just with a different status and less duplicated code.
LeoCavaille
added a commit
that referenced
this pull request
Dec 10, 2014
Add service check for gunicorn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alerts critical if no process with given name is found or if no workers are present (idle or running).
OK if workers are running or idle.
Description for UI: https://github.com/DataDog/dogweb/pull/5844