SNMP new types support + bug fix #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
yannmh
commented
Jan 27, 2015
yannmh
commented
- Add Integer and Integer32 type support
- Change the SNMP get command logic to solve the 'Missing OID' issue
- Some PEP8 code cleaning
* Change the SNMP get command logic to solve the 'Missing OID' issue * Some PEP8 code cleaning
| self.raise_on_error_indication(error_indication, instance) | ||
|
|
||
| # Continue on error_status | ||
| if error_status: |
There was a problem hiding this comment.
This is a bit odd.
You created a function to deal with error_indication but you didn't with error_status, while the logic looks quite the same (except that one is raising an error).
What I suggest is something like this:
if error_indication:
report_error_indication(error_indication, instance)
if error_status:
report_error_status(error_status, instance)There was a problem hiding this comment.
report_error_indication is raising an Exception and stops the check execution.
The reason why I didn't factorize report_error_status is because it has a continue (c.f your comment below) statement which refers directly to the upper level for loop.
|
Looking good! |
LeoCavaille
added a commit
that referenced
this pull request
Jan 28, 2015
SNMP new types support + bug fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.