[etcd] service check & test #1379
Conversation
degemer
commented
Feb 18, 2015
degemer
commented
- send a service check on success and on failure (previously only on failure)
- add a basic test copied from fluentd one
| @@ -112,4 +112,5 @@ def get_json(self, url, timeout): | |||
| tags = ["url:{}".format(url)]) | |||
| return None | |||
|
|
|||
| self.service_check(self.SERVICE_CHECK_NAME, AgentCheck.OK, tags=["url:{}".format(url)]) | |||
There was a problem hiding this comment.
Watchout, you'll end up sending two statuses per iteration, one for get_self_metrics and one for get_store_metrics.
Can you ensure to only send one status per iteration per instance ?
There was a problem hiding this comment.
You need to use {0} otherwise this is not python 2.6 comptible
There was a problem hiding this comment.
@remh: indeed, fixed now.
@LeoCavaille: also fixed. (and thanks for the explanation)
degemer
force-pushed
the
quentin/etcd-service_check
branch
2 times, most recently
from
eaccce4 to
929d73b
Compare
|
Finally send one and only one service_checks, thanks to @remh . |
And not only CRITICAL when unable to get metrics.
This is needed as the service check won't appear on the monitor screen
otherwise.
Fix python2.6 compatibility issue: "{}".format()
degemer
force-pushed
the
quentin/etcd-service_check
branch
from
929d73b to
546668b
Compare
| end | ||
|
|
||
| task :cleanup => ['ci:common:cleanup'] do | ||
| sh %(rm -rf $VOLATILE_DIR/etcd* || echo 'etcd not running') |
There was a problem hiding this comment.
You don't need to clean up VOLATILE_DIR it's already taken care of by the common cleanup task.
However, you might want to kill the etcd daemon you launched in the before_script stage, either by using a pidfile if you can have one or by using an appropriate kill command.
Copied from the apache/riackcs tests, using the AgentCheckTest.
degemer
force-pushed
the
quentin/etcd-service_check
branch
from
546668b to
3f537dc
Compare
Add assertServiceCheck (same principle than assertMetrics) in AgentCheckTest. If service_checks does not exist, retrieve latest data from AgentCheckTest.check.
degemer
force-pushed
the
quentin/etcd-service_check
branch
from
9f6fa62 to
ad405a2
Compare
Because of the changes in AgentCheckTest, old test was failing (because of the new error catch and reraise in run_check). It now uses assertServiceCheck.
|
LGTM 👍 |
[etcd] service check & test
|
Changes Unknown when pulling af75929 on quentin/etcd-service_check into * on master*. |
|
Changes Unknown when pulling af75929 on quentin/etcd-service_check into * on master*. |
