-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wmi] extend tagging for related class & constants #1388
Conversation
88ea2f3
to
33423cd
Compare
# `constant_tags` optionally lets you tag each metric with a set of fixed values | ||
# | ||
# `link_tag` optionally specifies how to join to another property for tagging. | ||
# Settings this will cause any instance number to be removed from tag_by values |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo Setting
Thanks Yann, looking good! Just two nitpicky comments, to make it look even nicer:
|
33423cd
to
9316166
Compare
Thanks @LeoCavaille ! |
Tried it on my box @yannmh , works well.
|
Also, maybe reword the comment for
|
d30d9b4
to
b720e9b
Compare
Thanks @LeoCavaille. I brought some changes following your feedback. I am merging it when Travis tests are passed, |
[[email protected]] Rebased on agent release 5.2.0 to fix conflicts
b720e9b
to
d1af6ea
Compare
[wmi] extend tagging for related class & constants
Changes Unknown when pulling d1af6ea on yann/wmi-extend-tagging into * on master*. |
Rebased #1253 on 5.2.0 agent release.
Added a few changes:
link_value
tags values (https://github.com/DataDog/dd-agent/compare/yann/wmi-extend-tagging?expand=1#diff-7a46560288aed829df125f0734b355f9R89)int
instead offloat
(experienced issues in my tests)Thanks a lot @rlaveycal