Fix bug when multiple instances were connecting to the same pg instance #1396
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, maybe we could add some testing around this logic? |
|
Also it broke the PG test cases. |
remh
pushed a commit
that referenced
this pull request
Feb 27, 2015
Fix bug when multiple instances were connecting to the same pg instance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1211
When multiple instances were connecting to the same pg instance, as metrics are not tagged by instance, We were collecting the same metrics multiple times leading to the errors described here:
#1211
This fixes it by not collecting common metrics across instances more than once.