[swap stats] add swap in/out check to checks.d #1549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return {} | ||
|
|
||
| swap_mem = psutil.swap_memory() | ||
| self.gauge('system.swap.swapped_in', swap_mem.sin / B2MB) |
There was a problem hiding this comment.
You should use a rate for these.
According to the psutil documentation, sin is
the number of bytes the system has swapped in from disk (cumulative)
By submitting the metric as a rate, you will compute the # of bytes per second swapped in.
Otherwise the graphs will just display a monotonically increasing value.
Also you should submit this value in bytes as per our discussion earlier.
| from checks import AgentCheck | ||
| import psutil | ||
|
|
||
| B2MB = float(1048576) |
talwai
force-pushed
the
talwai/swap_stats
branch
from
2963984 to
ff718ac
Compare
|
That looks great! 💥 |
|
👍 |
|
You should also use a "Fixes #716" expression to link that to currently opened issues. |
talwai
force-pushed
the
talwai/swap_stats
branch
from
ff718ac to
52f11f3
Compare
talwai
added a commit
that referenced
this pull request
Apr 16, 2015
[swap stats] add swap in/out check to checks.d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses
psutilto collect the rate of memory swapped in and swapped out. New metrics are labelledsystem.swap.swapped_inandsystem.swap.swapped_out.Fixes #716