Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HAProxy timer metrics #1579

Closed

Conversation

warnerpr
Copy link

There are useful to see backend performance. They are new in HAProxy 1.5, but the collector should still work with older versions.

From http://cbonte.github.io/haproxy-dconv/configuration-1.5.html#9.1:

 58. qtime [..BS]: the average queue time in ms over the 1024 last requests
 59. ctime [..BS]: the average connect time in ms over the 1024 last requests
 60. rtime [..BS]: the average response time in ms over the 1024 last requests
     (0 for TCP)
 61. ttime [..BS]: the average total session time in ms over the 1024 last
     requests

There are useful to see backend performance.  There are new in HAProxy 1.5, see http://cbonte.github.io/haproxy-dconv/configuration-1.5.html#9.1
Change should still work with older HAProxy
@LeoCavaille
Copy link
Member

Thanks @warnerpr for your contribution!
We're working on fixing the CI, but the sub-job of HAproxy (which is running 1.5 for integration testing) on python 2.7 seem to have succeeded which is the most important 😉
Let's do a final review and merge this for 5.4.

@LeoCavaille
Copy link
Member

@warnerpr reviewed and merged your changes in a rebased version:

  • bbc3412
    I also added on top c6eee4f to add more versions of HAProxy integration testing in our CI, to ensure non-regression for the future.
    Thanks again!

@LeoCavaille LeoCavaille closed this May 1, 2015
@LeoCavaille LeoCavaille self-assigned this May 1, 2015
@warnerpr
Copy link
Author

warnerpr commented May 1, 2015

Nice. Thanks @LeoCavaille. Great idea to test against the older versions.

@warnerpr warnerpr deleted the warnerpr/haproxy_merged_collapsed branch May 1, 2015 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants