[postgres] add support for relation schemas #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syncing with master
|
Thanks Kostas ! |
|
Added config syntax example. |
| # | ||
| # relations: | ||
| # - relation_name: another_table | ||
| # schemas: public prod |
There was a problem hiding this comment.
schemas should be a yaml list, instead of a space separated list
|
Thanks for the suggestions, now updated, please take a look. |
|
Looks good to me! |
remh
pushed a commit
that referenced
this pull request
Jul 23, 2015
[postgres] add support for relation schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change populates an additional tag for postgres relations containing the schema name. With this separate tag we can disambiguate metrics coming from same name tables but in separate schemas (e.g. staging vs production).
In addition we can now limit publishing to specific relation schemas via configuration.
Original issue #1496.