Force exclusion of CDROM (iso9660) from disk check #1786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JohnLZeller
force-pushed
the
zeller/exclude-cdrom
branch
from
3dc1e72 to
4540d67
Compare
|
Nice but as far as i can see iso9660 is for Windows only. Did you try this on a linux host ? |
|
Also it seems that for windows, the CD rom case is already covered: |
|
Bah, I'll take another look at this. |
|
Looks like iso9660 is for both Windows and Linux. I tested on Linux, and sure enough the fstype is iso9660. Testing now between this change, and how we did things with 5.3.0 |
|
Agent 5.3.0 reports disk usage for read-only disks. This PR will exclude mounted cdrom disks, but preserves the behavior of agent 5.3.0 reporting disk usage of read-only disks. |
remh
pushed a commit
that referenced
this pull request
Aug 10, 2015
Force exclusion of CDROM (iso9660) from disk check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the agent disk check is including the monitoring of mounted cd-rom images. This isn't good as these are read-only and already have 100% usage. This is a threat for triggers false positives.
Solution is to forcibly exclude CDROM (iso9660) filesystems from the disk check.