Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[elastic] Added common JVM metrics #1865

Merged
merged 1 commit into from
Aug 27, 2015
Merged

[elastic] Added common JVM metrics #1865

merged 1 commit into from
Aug 27, 2015

Conversation

elafarge
Copy link
Contributor

The metrics heap_used_percent and heap_max_in_bytes have been added
to the elasticsearch integration following up a customer request.

@elafarge elafarge force-pushed the etienne/es-jvm-metrics branch from a9ee9c2 to f19856b Compare August 26, 2015 16:47
@@ -163,6 +163,8 @@ class ESCheck(AgentCheck):
"elasticsearch.http.total_opened": ("gauge", "http.total_opened"),
"jvm.mem.heap_committed": ("gauge", "jvm.mem.heap_committed_in_bytes"),
"jvm.mem.heap_used": ("gauge", "jvm.mem.heap_used_in_bytes"),
"jvm.mem.heap_used_in_percents": ("gauge", "jvm.mem.heap_used_percent"),
"jvm.mem.heap_max_in_bytes": ("gauge", "jvm.mem.heap_max_in_bytes"),
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the _in_bytes is unnecessary

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just got rid of it :)

@elafarge elafarge force-pushed the etienne/es-jvm-metrics branch from f19856b to 9686525 Compare August 27, 2015 15:16
The metrics `heap_used_percent` and `heap_max_in_bytes` have been added
to the elasticsearch integration following up a customer request.
@elafarge elafarge force-pushed the etienne/es-jvm-metrics branch from 9686525 to ad83f17 Compare August 27, 2015 15:29
@yannmh
Copy link
Member

yannmh commented Aug 27, 2015

👍

@elafarge
Copy link
Contributor Author

@remh @yannmh Shall I ?

@yannmh
Copy link
Member

yannmh commented Aug 27, 2015

Go for it 🚄

@yannmh yannmh self-assigned this Aug 27, 2015
elafarge added a commit that referenced this pull request Aug 27, 2015
@elafarge elafarge merged commit ee21eea into master Aug 27, 2015
@elafarge elafarge deleted the etienne/es-jvm-metrics branch August 27, 2015 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants