Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[darwin][iostat] Fix bad conversion #1912

Merged
merged 1 commit into from
Sep 14, 2015
Merged

[darwin][iostat] Fix bad conversion #1912

merged 1 commit into from
Sep 14, 2015

Conversation

remh
Copy link

@remh remh commented Sep 14, 2015

Fix #1718

@@ -72,7 +72,7 @@ def _parse_darwin(self, output):
for idx, disk in enumerate(disks):
kb_t, tps, mb_s = map(float, lastline[(3 * idx):(3 * idx) + 3]) # 3 cols at a time
io[disk] = {
'system.io.bytes_per_s': mb_s * 10**6,
'system.io.bytes_per_s': mb_s * 2**20,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb_s << 20 ?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mb_s is a float, so that wouldn't work but yeah i agree it would be better otherwise.

@remh remh added this to the 5.5.0 milestone Sep 14, 2015
@yannmh yannmh self-assigned this Sep 14, 2015
remh pushed a commit that referenced this pull request Sep 14, 2015
[darwin][iostat] Fix bad conversion
@remh remh merged commit 279dabb into master Sep 14, 2015
@remh remh deleted the remh/fix_mac_iostat branch September 15, 2015 19:01
yannmh added a commit that referenced this pull request Sep 15, 2015
urosgruber pushed a commit to urosgruber/dd-agent that referenced this pull request Dec 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants