Update http_check.py #1923
Closed
Update http_check.py #1923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix SSL cert check when specifying a non-default port in the URL.
Currently if you specify something like the following in your http_check.yaml file, then the SSL check will fail as o.netloc will return "localhost:2610" instead of just "localhost".
url: https://localhost:2610/status
|
Thanks for addressing the issue @dmulter ! We'll merge your PR really soon 🚢 Also, we recently introduced some contribution guidelines to keep a nice, homogeneous, and easy to browse git history. Would you mind rewording the commit title following these rules please ? Again, thank you for your contribution. |
|
#1944 replaces this PR. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix SSL cert check when specifying a non-default port in the URL.
Currently if you specify something like the following in your http_check.yaml file, then the SSL check will fail as o.netloc will return "localhost:2610" instead of just "localhost".