[http_check] Adding a days_critical to the SSL certificate expiration feature #2087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
truthbk
force-pushed
the
jaime/httpcheck_sslcrit
branch
from
e72f056 to
3ca8f1d
Compare
|
I was contemplating this exact feature! This would be really useful. |
| @@ -18,6 +18,7 @@ | |||
| class Status: | |||
| DOWN = "DOWN" | |||
| WARNING = "WARNING" | |||
| CRITICAL = "CRITICAL" | |||
There was a problem hiding this comment.
Not sure that it makes much sense to add a new "CRITICAL" status here. These statuses seem to have been primarily used before we had actual service checks, and service checks now only have 3 states (OK, WARNING, CRITICAL).
So I would use a Status.DOWN status for this new threshold.
There was a problem hiding this comment.
@olivielpeau the thing is I don't like setting DOWN when it's not really true. I create that redundant state for better code readability - if you disagree I'm happy to change it back again.
|
After some discussion, we'll keep the new This looks good to merge, thanks @truthbk! |
Adding days_critical to test and config. Adding check for critical days for certificate expiration warning.
truthbk
force-pushed
the
jaime/httpcheck_sslcrit
branch
from
ff1021f to
8fed4c9
Compare
truthbk
added a commit
that referenced
this pull request
Nov 20, 2015
[http_check] Adding a days_critical to the SSL certificate expiration feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check will now raise a critical warning if we're within the specified CRITICAL range before a certificate expires.