-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cassandra] Add YAML for Cassandra version > 2.2 #2142
Conversation
- system | ||
- system_auth | ||
- system_distributed | ||
- system_traces |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add OpsCenter to this list? It's a very common tool and I don't think anyone cares about metrics on it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your feedback on it @sethrosenblum. I am adding it to the list of exclusion.
[[email protected]] Rebased to comply with contribution guidelines. Also added `keyspace=OpsCenter` to the list of exclusions.
2df7566
to
2466541
Compare
We are entirely dropping the old Cassandra YAML configuration file. @remh can you take a pass on this PR and merge it please ? |
[cassandra] Add YAML for Cassandra version > 2.2
Thanks! |
* Enhance `DatadogMonitor` resource with a `version` attribute. * Use `version` attribute in `cassandra` recipe to version, i.e. select the appriopriate YAML configuration file. Two versions are currently available * `1` (Default): Legacy YAML configuration file, compatible with Cassandra < 2.2. * `2`: Required for Cassandra > 2.2, use the YAML configuration file * introduced with DataDog/dd-agent@2df7566 * Enable `cassandra_aliasing` option to comply with DataDog/dd-agent#2035 More information: DataDog/dd-agent#2142
* Enhance `DatadogMonitor` resource with a `version` attribute. * Use `version` attribute in `cassandra` recipe to version, i.e. select the appriopriate YAML configuration file. Two versions are currently available * `1` (Default): Legacy YAML configuration file, compatible with Cassandra < 2.2. * `2`: Required for Cassandra > 2.2, use the YAML configuration file * introduced with DataDog/dd-agent@2df7566 * Enable `cassandra_aliasing` option to comply with DataDog/dd-agent#2035 More information: DataDog/dd-agent#2142
Thanks @johnaxel
Related PR
DataDog/chef-datadog#263