[mongo] report dbtop metrics #2166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[[email protected]] rebased to fix conflicts.
**Additional changes** * Add the corresponding `top` option in `additional_metrics` * Clean up `top` metric collection code to comply with the current code state.
yannmh
force-pushed
the
yann/report-dbtop-rebase
branch
from
2c67e0c to
faacae0
Compare
|
Looks good to me! Let's wait for master to be in a good state (#2168) before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #1906
Additional changes
topoption inadditional_metricstopmetric collection code to comply with the current codestate.
Thanks again @scottbessler.