[dogstatsd] Recover gracefully from serialization errors #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
olivielpeau
commented
Jan 4, 2016
olivielpeau
commented
- try to skip errors so that we can serialize what we can
- add a metric on serialization status
| try: | ||
| metrics.append(add_serialization_status_metric("success", hostname)) | ||
| serialized = json.dumps({"series": metrics}) | ||
| except (UnicodeDecodeError, Exception) as e: |
- try to skip errors so that we can serialize what we can - add a metric on serialization status
olivielpeau
force-pushed
the
olivielpeau/unicode-safe-serialization
branch
from
d24809f to
718dc33
Compare
remh
pushed a commit
that referenced
this pull request
Jan 5, 2016
…ization [dogstatsd] Recover gracefully from serialization errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.