[core][wmi] gracefully timeout WMI queries #2185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannmh
force-pushed
the
yann/wmi-timeout
branch
5 times, most recently
from
c9322ea to
c4a1af5
Compare
|
Looks good to me, well done! The failures on Travis look related to the python libs issues that have been solved in master, could you rebase the PR to make it work? Once the tests pass I'm all for 🚢 ing this! |
yannmh
force-pushed
the
yann/wmi-timeout
branch
from
c4a1af5 to
0c93669
Compare
A decorator to timeout a function. Decorated method calls are executed in a separate new thread with a specified timeout. Also check if a thread for the same function already exists before creating a new one.
Timeout WMI queries after 10seconds with a warning message and no data. Recover at next iteration retrieving the existing query.
Less thread safety error-prone `WMISampler`: have one active query per
connection at a time.
* `_get_connection` → `get_connection`, a context manager that
* returns an existing and available WMI connection, or create one if
needed
* release it, i.e. mark it as available when done
yannmh
force-pushed
the
yann/wmi-timeout
branch
from
0c93669 to
d78881e
Compare
yannmh
added a commit
that referenced
this pull request
Jan 14, 2016
[core][wmi] gracefully timeout WMI queries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[utils] decorator to timeout a function
A decorator to timeout a function. Decorated method calls are executed in a separate new thread with a specified timeout.
Also check if a thread for the same function already exists before creating a new one.
[core][wmi] gracefully timeout WMI queries
Timeout WMI queries after 10seconds with a warning message and no data.
Recover at next iteration retrieving the existing query.
[core][wmi] one active query / connection
Less thread safety error-prone
WMISampler: have one active query per connection at a time._get_connection→get_connection, a context manager thatneeded