[hdfs] Bugfix updated bean name in datanode check #2260
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,12 +76,10 @@ def _hdfs_datanode_metrics(self, jmx_uri): | |||
|
|
|||
| if beans: | |||
|
|
|||
| # Only get the first bean | |||
| bean = next(iter(beans)) | |||
| bean_name = bean.get('name') | |||
There was a problem hiding this comment.
Could you self.log.debug the retrieved bean_name here, so that we can easily troubleshoot issues with the retrieved bean?
There was a problem hiding this comment.
That should also fix the flake8 tests.
|
Only has one small comment, once it's addressed the PR should be good to go, thanks! |
zachradtka
force-pushed
the
minerkasch/hdfs-jmx
branch
from
9cbff71 to
eb9ad8e
Compare
|
OK, I squashed commit's and pushed. |
|
Looks good, thanks! Merging (the CI failures are unrelated). |
olivielpeau
added a commit
that referenced
this pull request
Feb 12, 2016
[hdfs] Bugfix updated bean name in datanode check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a quick bugfix that updates bean name being requested from the DataNode's JMX interface.