Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded /proc #2267

Closed
gtmtech opened this issue Feb 15, 2016 · 2 comments
Closed

Remove hardcoded /proc #2267

gtmtech opened this issue Feb 15, 2016 · 2 comments
Assignees
Milestone

Comments

@gtmtech
Copy link

gtmtech commented Feb 15, 2016

See end of PR #2202

"This uses a hard-coded /proc which means it won't work when running in a docker container..."

This is a regression from the work that was done to make it proc agnostic (see 2163)

@remh remh added this to the 5.8.0 milestone Feb 19, 2016
@remh
Copy link

remh commented Feb 19, 2016

Hi @gtmtech thanks for the feedback!

It's not really a regression as it's not breaking anything ;) but i agree it should be an option!

I'll schedule this for 5.8.0 but not sure if it will make it as our 5.8.0 backlog is already big.

We would definitely welcome a patch though.

Thanks again for the feedback!

@olivielpeau olivielpeau assigned hkaj and truthbk and unassigned hkaj Apr 29, 2016
@yannmh yannmh modified the milestones: 5.8.0, 5.8.3 May 24, 2016
@gmmeyer gmmeyer modified the milestones: 5.8.3, 5.8.5 Jul 13, 2016
@olivielpeau
Copy link
Member

Fixed by #2482, scheduled for 5.9.0

@olivielpeau olivielpeau modified the milestones: 5.9.0, 5.8.5 Jul 20, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants