[wmi] if we timeout return an empty list to avoid exceptions. #2278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -54,12 +54,12 @@ def check(self, agentConfig): | |||
| u"Timeout while querying Win32_PerfRawData_PerfOS_System WMI class." | |||
| u" Processes metrics will be returned at next iteration." | |||
| ) | |||
| return | |||
| return [] | |||
|
|
|||
| if not (len(self.wmi_sampler)): | |||
| self.logger.info('Missing Win32_PerfRawData_PerfOS_System WMI class.' | |||
There was a problem hiding this comment.
Can we take advantage of this PR to change these log levels to warning instead of info ? What do you think ?
There was a problem hiding this comment.
Sure, I agree that warning is probably more adequate for the len()==0 cases! Will change to warning and merge.
|
Nice catch @truthbk, thanks for the fix. Feel free to merge. |
[wmi] adjusting message log level to warning
truthbk
force-pushed
the
jaime/wmi_fix
branch
from
2aa3347 to
76968e2
Compare
truthbk
added a commit
that referenced
this pull request
Feb 23, 2016
[wmi] if we timeout return an empty list to avoid exceptions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.