[haproxy] ` ̶c̶o̶l̶l̶a̶t̶e̶_̶s̶t̶a̶t̶u̶s̶_̶t̶a̶g̶s̶_̶p̶e̶r̶_̶h̶o̶s̶t̶… #2314
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you also remove the Lines 26 to 32 in f6b7545 |
|
Apart from my comment it looks good to me! |
…` option HAProxy newly introduced `collate_status_tags_per_host` option does not appropriately aggregates metrics when a backend is associated to multiple service. Remove it, to fix it.
yannmh
force-pushed
the
yann/haproxy-remove-status-collation-option
branch
from
f6b7545 to
c6f9c6f
Compare
|
👍 |
olivielpeau
added a commit
that referenced
this pull request
Mar 2, 2016
…ation-option [haproxy] ` ̶c̶o̶l̶l̶a̶t̶e̶_̶s̶t̶a̶t̶u̶s̶_̶t̶a̶g̶s̶_̶p̶e̶r̶_̶h̶o̶s̶t̶…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` option
HAProxy newly introduced
collate_status_tags_per_hostoption does notappropriately aggregates metrics when a backend is associated to
multiple service. Remove it, to fix it.