Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wmi] Filter documentation #2368

Closed
mausch opened this issue Mar 18, 2016 · 1 comment
Closed

[wmi] Filter documentation #2368

mausch opened this issue Mar 18, 2016 · 1 comment
Assignees
Milestone

Comments

@mausch
Copy link

mausch commented Mar 18, 2016

The comment in https://github.com/DataDog/dd-agent/blob/master/checks/libs/wmi/sampler.py#L314-L317 says that * is a valid wilcard to use in WMI filters, but it's not actually processed in the code that follows said comment.
Only % is processed, which is fine, but I think the * should be removed from that comment.
A filter with * is also used in https://help.datadoghq.com/hc/en-us/articles/205016075-How-to-retrieve-WMI-metrics , it should be changed to %

Also there are no examples of wildcards in https://github.com/DataDog/dd-agent/blob/master/conf.d/wmi_check.yaml.example

@yannmh yannmh added this to the 5.8.0 milestone Apr 6, 2016
@yannmh
Copy link
Member

yannmh commented Apr 6, 2016

Sorry for the late answer @mausch.

You are completely right, we'll fix that shortly ! Thanks again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants